Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#find_all does not behave like Enumerable#find_all #1284

Closed
denisdefreyne opened this issue Dec 27, 2017 · 0 comments
Closed

#find_all does not behave like Enumerable#find_all #1284

denisdefreyne opened this issue Dec 27, 2017 · 0 comments
Labels
type:bug 🐛

Comments

@denisdefreyne
Copy link
Member

IdentifiableCollection#find_all takes one argument, while Enumerable#find_all takes a block.

This is confusing, because even though IdentifiableCollection is Enumerable, not all of Enumerable’s methods behave as expected.

Suggestion: allow IdentifiableCollection#find_all to also be called with a block and no arguments, which would make it behave like Enumerable#find_all.
denisdefreyne added a commit that referenced this issue Dec 28, 2017
@denisdefreyne
Merge pull request #1285 from nanoc/gh-1284-find-all-with-block
7fbd217 
Let #find_all take a block (fixes #1284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denisdefreyne