On EACCES, copy instead of hardlink #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
handle-eaccess-in-item-rep-writer
branch
from
1c2ec62
to
f0f45dd
Compare
denisdefreyne
changed the title
|
CI isn’t my friend today (appears to be testing the wrong commit) but merging anyway (build passes locally) and will verify that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1405. (Or rather, works around the issue…)
It is possible for hardlinking to fail when copying works fine. In that case, fall back to copying instead of hardlinking.
To do: Figure out a way to test this.
Why?
According to facebook/create-react-app#1832 (comment):