Allow checks file naming variants

[cdlm]

No description provided.

[denisdefreyne]

Hmm, I’m not sure about this.

I consider the fact that Rules can have four different names a mistake: I should have stuck with Rules only. A .rb extension could be useful for syntax highlighting, but a #!/usr/bin/env ruby would solve that too.

So, allowing different filenames for Checks is something I’d rather not do. I am a proponent of “consistently wrong” though, and it would apply in this case.

[bobthecow]

@ddfreyne A counterpoint to that would be that I had to change my rules filenames when i added import_rules to the DSL. On a case-insensitive filesystem, you can't have a folder named rules/ and a file named Rules, so I now use rules.rb and rules/.

[denisdefreyne]

Alright, I’m convinced.

@cdlm Can you make this pull request on master instead of release-3.6.x? Edit: release branch is fine

[bobthecow]

Alternatively, we could implement that "explicit directory / path config" thing we talked about back in the day, then the only hardcoded filename would be config.yaml / nanoc.yaml :)

[denisdefreyne]

I think there’s enough configuration options already, so I’m not in favour of adding new ones.

[bobthecow]

I disagree. I still can't change the location of my tmp directory (unless this was added when I wasn't paying attention?)

[denisdefreyne]

Moved to a new issue #259.

[denisdefreyne]

Important change for code quality: 238a378 removes all work from the constructor (because a constructor should never do any work).