Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DependencyTracker's @stack causes "SystemStackError: forwardable.rb:204: stack level too deep" #325

Closed
sankl opened this issue Jul 25, 2013 · 1 comment

Comments

@sankl
Copy link

sankl commented Jul 25, 2013

DependencyTracker::start's @stack gets improper state if compilation fails in Compiler::compile_rep method: ':visit_ended' event is not posted and last item never pops out. This leads to incorrect dependency graph and then to stack overflow during recursively checking outdated items in OutdatednessChecker::outdated_due_to_dependencies? is_outdated = ...

There are two solutions to this:

  1. Compiler::compile_rep should 'ensure' that ':visit_ended' is posted.
    or
  2. DependencyTracker::start should handle ':compilation_failed' and reset the @stack = []
@denisdefreyne
Copy link
Member

This was fixed in #329 and released in 3.6.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants