CDN support #451
Merged
CDN support #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any problem with the pull/patch? |
|
My apologies. I haven’t had the time to review it yet. |
| @@ -65,6 +72,7 @@ def run | |||
| files = files + set | |||
| end | |||
| keys_to_destroy = files.all.map { |file| file.key } | |||
| keys_to_invalidate = Array.new | |||
There was a problem hiding this comment.
Idiomatic Ruby uses [] instead of Array.new.
|
Thanks. implemented all suggestions. Let me know if there's anything else. |
|
Looks good otherwise. Can you squash your six commits together? I’ll merge afterwards. |
|
That should be it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented support for CDN
if cdn_id is specified, it will invalidate objects on CDN.
Implemented fixes as Fog does not support dry run. Also, basic test is implemented.