Fix crash when compiling extensionless binary items #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,7 +130,7 @@ def array_to_yaml(array) | |||
| item.identifier.chop + '.css' | |||
| elsif item.binary? | |||
| # Write item with identifier /foo/ to /foo.ext | |||
| item.identifier.chop + '.' + item[:extension] | |||
| item.identifier.chop + '.' + (item[:extension] ? '.' + item[:extension] : '') | |||
There was a problem hiding this comment.
Oh, doh. That’s clearly wrong.
(Must have been my lack of coffee.)
|
looks good 👍 |
denisdefreyne
force-pushed
the
fix-extensionless-binary-items-crash
branch
from
464dc5f
to
12b6e8e
Compare
denisdefreyne
added a commit
that referenced
this pull request
Jan 31, 2015
Fix crash when compiling extensionless binary items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #524.