Add DateTime handling to attribute_to_time #717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances
attribute_to_time
which previously removed all timeinformation from a DateTime. This happened because DateTime identifies
itself as a Date.
Up to now, if
time.is_a?(Date)
is true,attribute_to_time
willcreate a new Time, with just year, month and day set. To fix that
behaviour, this commit adds a new condition at the beginning of
attribute_to_time
, which usestime.to_time
as long astime
is aDateTime.