Fix #attribute_to_time timezone issues #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
added a commit
that referenced
this pull request
Nov 10, 2015
Fix #attribute_to_time timezone issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When give a
DateorStringinstance,#attribute_to_timedoes not have timezone information, and so I believe the correct approach is to treat the argument as local time. The tests failed in UTC since they did not take the time offset into account.This PR makes the argument be treated as local time. (Enhancement rather than a bug, because it’s mostly the specs being wrong, and the documentation being vague.)
A small bonus change involves refactoring
#attribute_to_timeso it no longer has assignments or explicit type checks withif.Also see #717.