New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run less filter on main fiber #1001
Conversation
|
False hope: |
Not quite working. I reported an issue to |
2f363a3
to
348f94f
Compare
Added a mechanism to make code execute on the main fiber, and made the less filter use it. This seems to work! |
CC @RubenVerborgh — can you verify that this PR fixes your problem (#999)? |
Will merge because I cannot reproduce the problem on Travis CI nor locally on a Debian VM. |
That was fast 😉 I'll test later today. |
The two new skipped Less specs are implemented in #1003. |
Looks good to me. |
This ensures that
Less
is always invoked on the main fiber. Potential fix/workaround for #999.Added
Filter#on_main_fiber
, which executes the given block on the main fiber. This is the main mechanism that makes the Less filter work again.Converted all Less tests to specs. These are high-level tests (compiling using the CLI) because the Less filter is somewhat annoying to test otherwise (it now requires interaction with the compiler).
Two new Less specs that did not exist before are skipped for now, as I can’t get them to work. Will investigate in another PR.