Support full identifiers in breadcrumbs #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
gh-1010-non-legacy-breadcrumbs
branch
2 times, most recently
from
eac9bfa
to
bdbf1ec
Compare
denisdefreyne
force-pushed
the
gh-1010-non-legacy-breadcrumbs
branch
from
bdbf1ec
to
bdc9339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for full identifiers (e.g.
/projects/nanoc.md) to#breadcrumbs_trail. Currently, only legacy identifiers (e.g./projects/nanoc/) are supported.Fix for #1010.
Detailed description
This change first of all refactors the existing code to construct a prefix array for a given item identifier. For example,
/projects/nanoc/is turned into['', '/projects', '/projects/nanoc']. This in turn is used to construct the array of item identifiers which will be the breadcrumbs trail.For full identifiers, the procedure is the same, with the main difference that the item matching
/index.*is treated specially. This item is considered the root item and has the same role as the/item when using legacy identifiers.Related issues