Do not reuse cached binary content

lib/nanoc/base/services/compiler/phases/cache.rb

@@ -26,7 +26,12 @@ def run(rep, is_outdated:)
 
     contract Nanoc::Int::ItemRep, C::KeywordArgs[is_outdated: C::Bool] => C::Bool
     def can_reuse_content_for_rep?(rep, is_outdated:)
-      !is_outdated && !@compiled_content_cache[rep].nil?
+      if is_outdated
+        false
+      else
+        cache = @compiled_content_cache[rep]
+        cache ? cache.none? { |_snapshot_name, content| content.binary? } : false
+      end
     end
   end
 end

spec/nanoc/base/services/compiler/phases/cache_spec.rb

@@ -69,12 +69,12 @@ def run(rep, is_outdated:) # rubocop:disable Lint/UnusedMethodArgument
     context 'not outdated' do
       let(:is_outdated) { false }
 
-      context 'cached compiled content available' do
+      context 'textual cached compiled content available' do
         before do
           compiled_content_cache[rep] = { last: Nanoc::Int::TextualContent.new('cached') }
         end
 
-        it 'reuses content from cache' do
+        it 'writes content to cache' do
           expect { subject }
             .to change { snapshot_repo.get(rep, :last) }
             .from(nil)
@@ -99,6 +99,41 @@ def run(rep, is_outdated:) # rubocop:disable Lint/UnusedMethodArgument
         end
       end
 
+      context 'binary cached compiled content available' do
+        let(:binary_content) { 'b1n4ry' }
+        let(:binary_filename) { Tempfile.open('test') { |fn| fn << binary_content }.path }
+
+        before do
+          compiled_content_cache[rep] = { last: Nanoc::Int::BinaryContent.new(binary_filename) }
+        end
+
+        it 'writes content to cache' do
+          expect { subject }
+            .to change { snapshot_repo.get(rep, :last) }
+            .from(nil)
+            .to(some_textual_content('wrapped content'))
+        end
+
+        it 'marks rep as compiled' do
+          expect { subject }
+            .to change { rep.compiled? }
+            .from(false)
+            .to(true)
+        end
+
+        it 'changes compiled content cache' do
+          expect { subject }
+            .to change { compiled_content_cache[rep] }
+            .from(last: some_binary_content(binary_content))
+            .to(last: some_textual_content('wrapped content'))
+        end
+
+        it 'does not send notification' do
+          expect(Nanoc::Int::NotificationCenter).not_to receive(:post).with(:cached_content_used, rep)
+          subject
+        end
+      end
+
       context 'no cached compiled content available' do
         include_examples 'calls wrapped'
       end

spec/nanoc/regressions/gh_1094_spec.rb

@@ -0,0 +1,22 @@
+describe 'GH-1094', site: true, stdio: true do
+  before do
+    File.write('content/a.dat', 'foo')
+    File.write('content/index.html', '<%= @items["/*.dat"].compiled_content %>')
+
+    File.write('Rules', <<EOS)
+  compile '/**/*.html' do
+    filter :erb
+    write item.identifier.to_s
+  end
+
+  passthrough '/**/*.dat'
+EOS
+  end
+
+  it 'raises CannotGetCompiledContentOfBinaryItem twice' do
+    2.times do
+      expect { Nanoc::CLI.run(%w(compile)) }
+        .to raise_wrapped_error(an_instance_of(Nanoc::Int::Errors::CannotGetCompiledContentOfBinaryItem))
+    end
+  end
+end

spec/spec_helper.rb

@@ -174,6 +174,32 @@ def sort(x)
   end
 end
 
+RSpec::Matchers.define :raise_wrapped_error do |expected|
+  supports_block_expectations
+
+  include RSpec::Matchers::Composable
+
+  match do |actual|
+    begin
+      actual.call
+    rescue Nanoc::Int::Errors::CompilationError => e
+      values_match?(expected, e.unwrap)
+    end
+  end
+
+  description do
+    "raise wrapped error #{expected.inspect}"
+  end
+
+  failure_message do |_actual|
+    "expected that proc would raise wrapped error #{expected.inspect}"
+  end
+
+  failure_message_when_negated do |_actual|
+    "expected that proc would not raise wrapped error #{expected.inspect}"
+  end
+end
+
 RSpec::Matchers.define :be_some_textual_content do |expected|
   include RSpec::Matchers::Composable