Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable KeySize #295

Merged
merged 5 commits into from May 20, 2024
Merged

Variable KeySize #295

merged 5 commits into from May 20, 2024

Conversation

arontsang
Copy link
Contributor

Exposes KeySize for KeyFactory.NewKey

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.37%. Comparing base (49e2c62) to head (c9d2417).

Files Patch % Lines
.../LettuceEncrypt/Internal/AcmeCertificateFactory.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   44.36%   44.37%           
=======================================
  Files          51       51           
  Lines        1181     1183    +2     
  Branches      136      136           
=======================================
+ Hits          524      525    +1     
- Misses        611      619    +8     
+ Partials       46       39    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natemcmaster natemcmaster merged commit 7ca3fcc into natemcmaster:main May 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants