fix: cleanup modal properties on close

[adamcikado]

No description provided.

[rigor789]

Thanks for the PR, I'll need to run some tests, at a glance, seems this would wipe the shared/global context. In fact I was looking at using provide/inject to handle this instead, to allow usage within script setup context as well as the templates. Might hold off on this PR for a bit, and explore the provide/inject route instead.

[heywhy]

@rigor789 This is a working example of using inject/provide, commit. If we will be preferring provide/inject, I think it will be appropriate we also provide a useNavigation hook and take away all global properties.

[heywhy]

Looking at this PR again, this implementation does work fine because one can't show multiple modals at once on mobile apps, unlike web apps.

[rigor789]

Looking at this PR again, this implementation does work fine because one can't show multiple modals at once on mobile apps, unlike web apps.

You can stack multiple modals if you use the target option (so you don't try showing a modal with a ViewController that's already presenting one), example: https://stackblitz.com/edit/nativescript-vue-nativescript-vue-dh6cyk?file=src%2Fcomponents%2FHome.vue

trim.AA6CF796-4196-44EA-947D-C6163DA08DB9.MOV

Screenrecorder-2023-06-20-12-45-46-380.mp4

[heywhy]

Thank you for the information. I did forget there is a target option because I rarely used it😅. Provide/inject should fix this issue and it’s more appropriate here.