Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add infoBy prop for frameworks #538

Merged
merged 8 commits into from May 26, 2023
Merged

Conversation

daybrush
Copy link
Member

Issue

#532

Details

@coveralls
Copy link

coveralls commented May 16, 2023

Coverage Status

Coverage: 0.0%. Remained the same when pulling 4c93fa8 on daybrush:sizeGroup#532 into a2d9dd5 on naver:master.

Copy link
Member

@WoodNeck WoodNeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -122,7 +122,7 @@
"@cfcs/core": "^0.0.5",
"@egjs/children-differ": "^1.0.1",
"@egjs/component": "^3.0.0",
"@egjs/grid": "^1.13.0",
"@egjs/grid": "^1.14.0-beta.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have to fix this to 1.14.0 after release.

Comment on lines 93 to 96
/**
* Grid class to apply Infinite function.
* @ko Infinite 기능을 적용할 Grid 클래스.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptions are misused.

@daybrush daybrush merged commit 6fd5c0b into naver:master May 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants