New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add infoBy prop for frameworks #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/infinitegrid/package.json
Outdated
@@ -122,7 +122,7 @@ | |||
"@cfcs/core": "^0.0.5", | |||
"@egjs/children-differ": "^1.0.1", | |||
"@egjs/component": "^3.0.0", | |||
"@egjs/grid": "^1.13.0", | |||
"@egjs/grid": "^1.14.0-beta.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have to fix this to 1.14.0
after release.
packages/infinitegrid/src/types.ts
Outdated
/** | ||
* Grid class to apply Infinite function. | ||
* @ko Infinite 기능을 적용할 Grid 클래스. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptions are misused.
Issue
#532
Details