Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasma 6 Port (#23) #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

audreylandgrave
Copy link
Contributor

@audreylandgrave audreylandgrave commented Mar 12, 2024

Plasma 6 Port (#23)

x11: works perfectly

wayland: works for the most part.
Status:

  • Edge gaps are not working on some specific windows.
  • Windows can't be maximized (confirmed)
  • Fixed: Installer was using v5 of the packaging tools so it couldn't be installed through the script

@nclarius
Copy link
Owner

Very cool, thanks a lot! I hope I'll get around to taking a look at it soon.

@v3ss0n
Copy link

v3ss0n commented Mar 26, 2024

working and looks good to me , please merge?

@mashrit
Copy link

mashrit commented Apr 6, 2024

Works on X11, does not work on wayland

@materemias
Copy link

The port doesn't handle windows moved from one monitor to the other properly: when nearing the edge of the monitor it constantly shrinks the size of the window

@cquasar
Copy link

cquasar commented Apr 12, 2024

Did not work on Wayland and after ./install.sh it does not show under Kwin Scripts on System Settings
Arch Linux
Plasma: 6.0.3

@audreylandgrave
Copy link
Contributor Author

I am running it on Wayland. What are you experiencing? No effect at all? Or just buggy?

@mashrit
Copy link

mashrit commented Apr 12, 2024

Does it work for you?
For me, when I maximize a window it just stays the same size and becomes maximized within the same space.

@cquasar
Copy link

cquasar commented Apr 12, 2024

I am running it on Wayland. What are you experiencing? No effect at all? Or just buggy?

There is no effect at all

When I install I get:

./install.sh
kf.package: Invalid metadata for package structure "KWin/Script"
Package type "KWin/Script" not found
Successfully installed /home/clint/CODE/tile-gaps-plasma-6-port

I look for it on Kwin Scripts and it is not in there

@cquasar
Copy link

cquasar commented Apr 12, 2024

Does it work for you? For me, when I maximize a window it just stays the same size and becomes maximized within the same space.

Does not work at all.

@materemias
Copy link

I am running it on Wayland. What are you experiencing? No effect at all? Or just buggy?

There is no effect at all

When I install I get:

./install.sh kf.package: Invalid metadata for package structure "KWin/Script" Package type "KWin/Script" not found Successfully installed /home/clint/CODE/tile-gaps-plasma-6-port

I look for it on Kwin Scripts and it is not in there

you can use the package.sh script to generate tile-gaps_v8.1.kwinscript. That can be installed from file.

@mashrit
Copy link

mashrit commented Apr 12, 2024

I am running it on Wayland. What are you experiencing? No effect at all? Or just buggy?

There is no effect at all

When I install I get:

./install.sh kf.package: Invalid metadata for package structure "KWin/Script" Package type "KWin/Script" not found Successfully installed /home/clint/CODE/tile-gaps-plasma-6-port

I look for it on Kwin Scripts and it is not in there

In the install.sh the code is

#!/bin/bash
name=$(grep -oP '"Id":\s*"[^"]*' ./metadata.json | grep -oP '[^"]*$')
kpackagetool5 --type=KWin/Script --install . || kpackagetool5 --type=KWin/Script --upgrade .
kwriteconfig5 --file kwinrc --group Plugins --key "$name"Enabled true
qdbus org.kde.KWin /KWin reconfigure

change it to

#!/bin/bash
name=$(grep -oP '"Id":\s*"[^"]*' ./metadata.json | grep -oP '[^"]*$')
kpackagetool6 --type=KWin/Script --install . || kpackagetool6 --type=KWin/Script --upgrade .
kwriteconfig6 --file kwinrc --group Plugins --key "$name"Enabled true
qdbus org.kde.KWin /KWin reconfigure

@materemias
Copy link

The port doesn't handle windows moved from one monitor to the other properly: when nearing the edge of the monitor it constantly shrinks the size of the window

I could resolve this by commenting out the subscription to frameGeometryChanged signal in onRegeometrized function

@audreylandgrave
Copy link
Contributor Author

audreylandgrave commented Apr 12, 2024

Hey if anyone wants to contribute, feel free to commit to the PR, I don't mind.

*updated the packaging tools version

@cquasar
Copy link

cquasar commented Apr 12, 2024

After the fix in the packaging tools versions I installed it and could see it under Kwin Scripts.

It does not work though. I cannot maximize nor "tile" my windows anymore. When I try to maximize the window it does not change its dimensions and position at all even though its "status" become maximized. When tilling it does not work and nothing happens.

With applications started with GDK_BACKEND=x11 the script works fine.

@audreylandgrave
Copy link
Contributor Author

After the fix in the packaging tools versions I installed it and could see it under Kwin Scripts.

It does not work though. I cannot maximize nor "tile" my windows anymore. When I try to maximize the window it does not change its dimensions and position at all even though its "status" become maximized. When tilling it does not work and nothing happens.

With applications started with GDK_BACKEND=x11 the script works fine.

thanks, I have experienced the "maximize" problem too, so it's now confirmed. I am keeping the list of issues updated in the description.

@probabilis
Copy link

gracias my friend - working perfectly here on x11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants