fix(ncyBreadcrumb): Prevent memory leak when label is a binding

Releases collection of watchers, preventing a leak when the label is a binding and not a string
ncuillery · May 2, 2015 · 264e10f · 264e10f
1 parent ef73525
commit 264e10f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/dist/angular-breadcrumb.js b/dist/angular-breadcrumb.js
@@ -1,4 +1,4 @@
-/*! angular-breadcrumb - v0.3.3-dev-2015-04-21
+/*! angular-breadcrumb - v0.3.3-dev-2015-05-02
 * http://ncuillery.github.io/angular-breadcrumb
 * Copyright (c) 2015 Nicolas Cuillery; Licensed MIT */
 
@@ -177,7 +177,6 @@ var deregisterWatchers = function(labelWatcherArray) {
     angular.forEach(labelWatcherArray, function(deregisterWatch) {
         deregisterWatch();
     });
-    labelWatcherArray = [];
 };
 
 function BreadcrumbDirective($interpolate, $breadcrumb, $rootScope) {
@@ -209,6 +208,8 @@ function BreadcrumbDirective($interpolate, $breadcrumb, $rootScope) {
 
                 var renderBreadcrumb = function() {
                     deregisterWatchers(labelWatchers);
+                    labelWatchers = [];
+
                     var viewScope = $breadcrumb.$getLastViewScope();
                     scope.steps = $breadcrumb.getStatesChain();
                     angular.forEach(scope.steps, function (step) {
@@ -255,6 +256,8 @@ function BreadcrumbLastDirective($interpolate, $breadcrumb, $rootScope) {
 
                     var renderLabel = function() {
                         deregisterWatchers(labelWatchers);
+                        labelWatchers = [];
+
                         var viewScope = $breadcrumb.$getLastViewScope();
                         var lastStep = $breadcrumb.getLastStep();
                         if(lastStep) {
@@ -318,6 +321,7 @@ function BreadcrumbTextDirective($interpolate, $breadcrumb, $rootScope) {
 
                     var renderLabel = function() {
                         deregisterWatchers(labelWatchers);
+                        labelWatchers = [];
 
                         var viewScope = $breadcrumb.$getLastViewScope();
                         var steps = $breadcrumb.getStatesChain();

diff --git a/dist/angular-breadcrumb.min.js b/dist/angular-breadcrumb.min.js
diff --git a/src/angular-breadcrumb.js b/src/angular-breadcrumb.js
@@ -172,7 +172,6 @@ var deregisterWatchers = function(labelWatcherArray) {
     angular.forEach(labelWatcherArray, function(deregisterWatch) {
         deregisterWatch();
     });
-    labelWatcherArray = [];
 };
 
 function BreadcrumbDirective($interpolate, $breadcrumb, $rootScope) {
@@ -204,6 +203,8 @@ function BreadcrumbDirective($interpolate, $breadcrumb, $rootScope) {
 
                 var renderBreadcrumb = function() {
                     deregisterWatchers(labelWatchers);
+                    labelWatchers = [];
+
                     var viewScope = $breadcrumb.$getLastViewScope();
                     scope.steps = $breadcrumb.getStatesChain();
                     angular.forEach(scope.steps, function (step) {
@@ -250,6 +251,8 @@ function BreadcrumbLastDirective($interpolate, $breadcrumb, $rootScope) {
 
                     var renderLabel = function() {
                         deregisterWatchers(labelWatchers);
+                        labelWatchers = [];
+
                         var viewScope = $breadcrumb.$getLastViewScope();
                         var lastStep = $breadcrumb.getLastStep();
                         if(lastStep) {
@@ -313,6 +316,7 @@ function BreadcrumbTextDirective($interpolate, $breadcrumb, $rootScope) {
 
                     var renderLabel = function() {
                         deregisterWatchers(labelWatchers);
+                        labelWatchers = [];
 
                         var viewScope = $breadcrumb.$getLastViewScope();
                         var steps = $breadcrumb.getStatesChain();