Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add ncyBreadcrumbState for ui-sref attribute #101

Closed
wants to merge 1 commit into from
Closed

fix: add ncyBreadcrumbState for ui-sref attribute #101

wants to merge 1 commit into from

Conversation

kiddo13
Copy link
Contributor

@kiddo13 kiddo13 commented Aug 21, 2015

No description provided.

@ncuillery
Copy link
Owner

Hi, sorry for the late answer.

The name of the state is a technical variable. Why do you need it in your template ?

@ncuillery
Copy link
Owner

Ooops forget my question, I just read your comment here #54 (comment)

@ncuillery
Copy link
Owner

OK, It looks legit to me 👍

Please can you:

  • revert your change on release/angular-breadcrumb.js (It is only changed with a new release)
  • rename the variable ncyBreadcrumbState to ncyBreadcrumbStateRefto be consistent with ui-router terminology (srefmeans "state ref").

Many thanks for the PR !

@ncuillery ncuillery mentioned this pull request Apr 12, 2016
Merged
@ncuillery
Copy link
Owner

I did the update myself in an other PR #141.

I cherry-picked your commit, so your name has been kept.

Thanks for contributing 👍

@ncuillery ncuillery closed this Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
answered waiting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiddo13 @ncuillery