fix: regularize mutation rate calculation #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GTR inference was failing when there were no mutations on the tree, i.e. the entire alignment consisted of identical sequences. In that case, there is not data to estimate a model. But the pseudo-count in the GTR inference should in principle then simply result in a flat JC-type model. However, the rate calculation wasn't properly regularized with pseudocounts and ended up being zero, leading to a division by 0 and subsequent NaN type errors.
fixes: #253