Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #499 rename 'getContentAsUnsignedInt64Scalar' to 'getContentAsUns… #500

Merged
merged 2 commits into from
Aug 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@

- [#464](http://github.com/Nelson-numerical-software/nelson/issues/464): simplify macos build (catalina & BigSur support only).

- [#499](http://github.com/Nelson-numerical-software/nelson/issues/499): rename `getContentAsUnsignedInt64Scalar` to `getContentAsUnsignedInteger64Scalar`.

- [#495](http://github.com/Nelson-numerical-software/nelson/issues/495): some mtimes call failed.

# 0.5.7 (2021-07-24)
Expand Down
4 changes: 2 additions & 2 deletions modules/assert_functions/src/cpp/Assert_IsEqual.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ formatMessage(const ArrayOf& computedArray, const ArrayOf& expectedArray)
std::to_wstring(expected).c_str(), std::to_wstring(computed).c_str());
} break;
case NLS_UINT64: {
uint64 computed = ArrayOf(computedArray).getContentAsUnsignedInt64Scalar();
uint64 expected = ArrayOf(expectedArray).getContentAsUnsignedInt64Scalar();
uint64 computed = ArrayOf(computedArray).getContentAsUnsignedInteger64Scalar();
uint64 expected = ArrayOf(expectedArray).getContentAsUnsignedInteger64Scalar();
message = StringFormat(_W("Assertion failed: expected (%ls) and computed (%ls) "
"values are different.")
.c_str(),
Expand Down
2 changes: 1 addition & 1 deletion modules/com_engine/src/cpp/VariantConversionHelpers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ NelsonToComVariant(ArrayOf A, VARIANT* variant, std::wstring& errorMessage)
return true;
} break;
case NLS_UINT64: {
uint64 r = A.getContentAsUnsignedInt64Scalar();
uint64 r = A.getContentAsUnsignedInteger64Scalar();
variant->vt = VT_UI8;
variant->llVal = r;
return true;
Expand Down
6 changes: 3 additions & 3 deletions modules/elementary_functions/builtin/cpp/repmatBuiltin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ Nelson::ElementaryFunctionsGateway::repmatBuiltin(
case 2: {
ArrayOf param2 = argIn[1];
if (param2.isScalar()) {
repcount[0] = (indexType)param2.getContentAsUnsignedInt64Scalar();
repcount[1] = (indexType)param2.getContentAsUnsignedInt64Scalar();
repcount[0] = (indexType)param2.getContentAsUnsignedInteger64Scalar();
repcount[1] = (indexType)param2.getContentAsUnsignedInteger64Scalar();
} else {
if (param2.isRowVector()) {
param2.promoteType(NLS_UINT64);
Expand All @@ -84,7 +84,7 @@ Nelson::ElementaryFunctionsGateway::repmatBuiltin(
default: {
for (size_t k = 1; k < argIn.size(); ++k) {
ArrayOf paramK = argIn[k];
repcount[k - 1] = (indexType)paramK.getContentAsUnsignedInt64Scalar();
repcount[k - 1] = (indexType)paramK.getContentAsUnsignedInteger64Scalar();
}
} break;
}
Expand Down
2 changes: 1 addition & 1 deletion modules/hdf5/src/cpp/h5Create.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ setFillValue(ArrayOf fillvalue, Class dataType, hid_t dcpl)
} break;
case NLS_UINT64: {
hid_t fillType = H5T_STD_U64LE;
uint64 value = fillvalue.getContentAsUnsignedInt64Scalar();
uint64 value = fillvalue.getContentAsUnsignedInteger64Scalar();
status = H5Pset_fill_value(dcpl, fillType, &value);
} break;
case NLS_UINT32: {
Expand Down
6 changes: 3 additions & 3 deletions modules/operators/src/cpp/Colon.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -456,15 +456,15 @@ Colon(const ArrayOf& J, const ArrayOf& I, const ArrayOf& K, bool& needToOverload
low = static_cast<uint64>(1);
high = static_cast<uint64>(0);
} else {
step = _I.getContentAsUnsignedInt64Scalar(true);
step = _I.getContentAsUnsignedInteger64Scalar(true);
if (!_I.isScalar()) {
warningArrayAsScalar = true;
}
low = _J.getContentAsUnsignedInt64Scalar(true);
low = _J.getContentAsUnsignedInteger64Scalar(true);
if (!_J.isScalar()) {
warningArrayAsScalar = true;
}
high = _K.getContentAsUnsignedInt64Scalar(true);
high = _K.getContentAsUnsignedInteger64Scalar(true);
if (!_K.isScalar()) {
warningArrayAsScalar = true;
}
Expand Down
2 changes: 1 addition & 1 deletion modules/qml_engine/src/cpp/QVariantArrayOf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ ArrayOfToQVariant(ArrayOf A, int id)
res = QVariant((long long)v);
} break;
case QMetaType::Type::ULongLong: {
uint64 v = A.getContentAsUnsignedInt64Scalar();
uint64 v = A.getContentAsUnsignedInteger64Scalar();
res = QVariant((unsigned long long)v);
} break;
case QMetaType::Type::Double: {
Expand Down
2 changes: 1 addition & 1 deletion modules/stream_manager/src/cpp/FscanFunction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ convertToArrayOf(ArrayOfVector& values, Class classDestination, bool haveThirdAr
switch (classDestination) {
case NLS_UINT64: {
for (indexType k = 0; k < nbValues; k++) {
ptr[k] = (T)values[k].getContentAsUnsignedInt64Scalar();
ptr[k] = (T)values[k].getContentAsUnsignedInteger64Scalar();
}
} break;
case NLS_INT64: {
Expand Down
2 changes: 1 addition & 1 deletion modules/time/builtin/cpp/calendarBuiltin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Nelson::TimeGateway::calendarBuiltin(int nLhs, const ArrayOfVector& argIn)
} break;
case 2: {
ArrayOf param1 = argIn[0];
uint64 cyear = param1.getContentAsUnsignedInt64Scalar();
uint64 cyear = param1.getContentAsUnsignedInteger64Scalar();
if (cyear < 1400 || cyear > 9999) {
Error(ERROR_WRONG_ARGUMENT_1_VALUE);
}
Expand Down
2 changes: 1 addition & 1 deletion modules/time/builtin/cpp/tocBuiltin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Nelson::TimeGateway::tocBuiltin(Evaluator* eval, int nLhs, const ArrayOfVector&
nargoutcheck(nLhs, 0, 1);
if (argIn.size() == 1) {
ArrayOf paramOne = argIn[0];
uint64 t = paramOne.getContentAsUnsignedInt64Scalar();
uint64 t = paramOne.getContentAsUnsignedInteger64Scalar();
double r = 0;
if (Toc(t, r)) {
ArrayOfVector retval(1);
Expand Down
2 changes: 1 addition & 1 deletion modules/types/src/cpp/ArrayOf_IntegersType.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ ArrayOf::getContentAsInteger64Scalar(bool arrayAsScalar) const
}
//=============================================================================
uint64
ArrayOf::getContentAsUnsignedInt64Scalar(bool arrayAsScalar) const
ArrayOf::getContentAsUnsignedInteger64Scalar(bool arrayAsScalar) const
{
return getContentAsScalar<uint64>(*this, NLS_UINT64, arrayAsScalar);
}
Expand Down
2 changes: 1 addition & 1 deletion modules/types/src/include/ArrayOf.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,7 @@ class NLSTYPES_IMPEXP ArrayOf
* Throws an exception if we are not a scalar integer type.
*/
uint64
getContentAsUnsignedInt64Scalar(bool arrayAsScalar = false) const;
getContentAsUnsignedInteger64Scalar(bool arrayAsScalar = false) const;

/**
* Get our contents as an integer scalar 64.
Expand Down
2 changes: 1 addition & 1 deletion modules/validators/src/cpp/ValidatorsInternal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ createPrintableScalar(const ArrayOf& c, const std::wstring& fmt, const std::wstr
valueAsString = std::to_wstring(value);
} break;
case NLS_UINT64: {
uint64 value = ArrayOf(c).getContentAsUnsignedInt64Scalar();
uint64 value = ArrayOf(c).getContentAsUnsignedInteger64Scalar();
valueAsString = std::to_wstring(value);
} break;
case NLS_INT64: {
Expand Down
2 changes: 1 addition & 1 deletion modules/webtools/src/cpp/WebREST.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ scalarValueToString(CURL* curlObject, ArrayOf& value)
s = std::to_string(v);
} break;
case NLS_UINT64: {
uint64 v = value.getContentAsUnsignedInt64Scalar();
uint64 v = value.getContentAsUnsignedInteger64Scalar();
s = std::to_string(v);
} break;
case NLS_INT64: {
Expand Down