disable contributions as client side rendered #132

nelsonic · Apr 23, 2024 · e612c1c · e612c1c
1 parent b79a4e9
commit e612c1c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/lib/org_repos.js b/lib/org_repos.js
@@ -39,6 +39,7 @@ function org_repos($, url, callback) {
     console.log($(parent))
     console.log($(parent + ' .markdown-title'))
     data.entries.push({
+      // feel free to add more attributes to this! 🙏
       name: $(parent + ' .markdown-title').text().trim(),
       // lang: $(parent + ' .listview-item-main-content').find('[class^="Text-"]').text().trim(),
       url: $(parent + ' a').first().attr('href'),

diff --git a/lib/profile.js b/lib/profile.js
@@ -46,9 +46,9 @@ module.exports = function profile ($, url, callback) {
   data.website  = $('[data-test-selector=profile-website-url] > a').attr("href")
   // data.joined   = $('.join-date').attr('datetime');       // Joined GitHub
 
-  // Contributions to Open Source in the past 12 months
-  data.contribs = parseInt($('.js-yearly-contributions').text().trim()
-    .split(' contributions')[0].replace(',', ''), 10);
+  // Contributions to Open Source in the past 12 months #132
+  // data.contribs = parseInt($('.js-yearly-contributions h2').text().trim()
+  //   .split(' contributions')[0].replace(',', ''), 10);
   // Contribution Matrix
   data = require('./profile_contribs.js')($, data);
 

diff --git a/lib/utils.js b/lib/utils.js
@@ -19,9 +19,6 @@ function parse_int (str) {
   , 10)
 }
 
-/**
- * A library of utility functions for parsing web data.
- */
 module.exports = {
   parse_int: parse_int
 }
diff --git a/test/profile.test.js b/test/profile.test.js
@@ -29,8 +29,8 @@ test(file + 'Scrape @nelsonic GitHub profile (consistent state profile)', functi
 
 		t.ok(data.following > 300, '- @' + user
 			+ ' Is following more than 300 people');
-		t.ok(data.contribs > 3000, '- @' + user + ' Has made ' + data.contribs
-			+ ' contributions to Open Source this year!');
+		// t.ok(data.contribs > 3000, '- @' + user + ' Has made ' + data.contribs
+		// 	+ ' contributions to Open Source this year!');
 
 		t.ok(data.pinned.length === 6, '- @' + user
 			+ ' Has Six "Pinned" Repositories');
@@ -60,9 +60,9 @@ test(file + 'Scrape @iteles detailed contribution matrix', function(t){
 	var user = 'iteles';
 	profile(user, function(err, data) {
 		t.ok(data.bio.match(/Co-founder/i), '- @' + user + ' bio: ' + data.bio);
-		t.ok(data.contribs > 100, '- @' + user + ' Has made ' + data.contribs
-			+ ' contributions to Open Source this year!');
-
+		// now client rendered so cannot parse! #132
+		// t.ok(data.contribs > 100, '- @' + user + ' Has made ' + data.contribs
+		// 	+ ' contributions to Open Source this year!');
 		t.end();
 	});
 });