Properly handle selectivities when many labels #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pontusmelke
force-pushed
the
2.2-selectivity-many-labels
branch
from
b39c008
to
f30b656
Compare
|
LGTM 👍 |
Because of the independency assumption we could end up in situations where label selectivities was larger than 1.0, and completely blow up when having many labels. Fixes GH#5336
pontusmelke
force-pushed
the
2.2-selectivity-many-labels
branch
from
f30b656
to
dafa279
Compare
systay
added a commit
that referenced
this pull request
Sep 24, 2015
Properly handle selectivities when many labels
| @@ -133,12 +132,12 @@ case class PatternSelectivityCalculator(stats: GraphStatistics, combiner: Select | |||
|
|
|||
| private def calculateLabelSelectivity(specs: Seq[TokenSpec[LabelId]]): Selectivity = { | |||
| val selectivities = specs map { | |||
| case SpecifiedButUnknown() => Selectivity(0) | |||
| case SpecifiedButUnknown() => Selectivity.ONE | |||
There was a problem hiding this comment.
This looks weird. It went from Selectivity(0) to Selectivity.ONE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the independency assumption we could end up in situations with
label selectivities larger than 1.0, and completely blow up when having
many labels.
Fixes #5336