Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Refactor main.c #659

Closed
wants to merge 1 commit into from
Closed

[RFC] Refactor main.c #659

wants to merge 1 commit into from

Conversation

mhinz
Copy link
Member

@mhinz mhinz commented Apr 30, 2014

Change main.c according to project's coding guideline.

Change main.c according to project's coding guideline.
@felipecrv
Copy link
Contributor

Can't we delay massive style changes? :( ping @justinmk @tarruda

@aktau
Copy link
Contributor

aktau commented May 1, 2014

Well it does look cleaner now, whether it be integrated now or in the future! I still see TRUE and FALSE though, you can lowercase those (even if you don't change the types to bool. (but preferable is looking if the type can be changed to bool though).

@KarboniteKream
Copy link
Contributor

@aktau I'm doing this in my PRs. I think it's better to leave those as they are, since it's easier for me to track, which were changed.

@justinmk
Copy link
Member

@mhinz If you are ok with licensing your past contributions under Apache 2.0, would you mind signing the CLA? See #883

@justinmk justinmk added the RFC label Nov 12, 2014
@mhinz mhinz closed this Feb 8, 2015
@jszakmeister jszakmeister removed the RFC label Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants