Support SSH options and keys in Jump Proxy #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excid3
force-pushed
the
jump-proxy-keys
branch
2 times, most recently
from
152c8f6
to
9f19a5a
Compare
This adds support for SSH options on the command line with the -o flag. You can pass them in as options when you instantiate the Proxy::Jump class. Keys and key_data from the SSH connection are also passed to the ssh proxy. The key_data strings are written to disk as Tempfiles and cleaned up when the Proxy::Jump object is garbage collected to ensure they exist when the ssh command is run.
excid3
commented
Jun 30, 2023
| @@ -10,7 +11,7 @@ module Proxy | |||
| # | |||
| # require 'net/ssh/proxy/jump' | |||
| # | |||
| # proxy = Net::SSH::Proxy::Jump.new('user@proxy') | |||
| # proxy = Net::SSH::Proxy::Jump.new('user@proxy', options: ["StrictHostKeyChecking=no"]) | |||
There was a problem hiding this comment.
Another option here would be making this more generic like:
proxy = Net::SSH::Proxy::Jump.new('user@proxy', flags: ["-o StrictHostKeyChecking=no"])Then users could pass in any SSH flags which would be more flexible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for SSH options on the command line with the -o flag. You can pass them in as options when you instantiate the Jump class.
Keys and key_data from the SSH connection are also passed to the ssh proxy. The key_data strings are written to disk as Tempfiles and cleaned up when the Jump object is garbage collected to ensure they exist when the ssh command is run.
This addresses a couple of issues like #653, #596, #617 and can be expanded to support other flags.