Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcim: fix tooltips in svg rack display #3973

Merged
merged 1 commit into from Jan 21, 2020
Merged

dcim: fix tooltips in svg rack display #3973

merged 1 commit into from Jan 21, 2020

Conversation

hellerve
Copy link
Contributor

Fixes: #3963

This PR fixes #3963 by adding a title to the individual slots of the element. Those are rendered as follows:

Bildschirmfoto 2020-01-21 um 16 19 01

So they aren’t quite as pretty and feature-rich as the old ones, but they show the same information. To emulate the old ones we have to tinker a little with JavaScript I fear, and I don’t feel equipped to do that in the SVG context.

@candlerb can you confirm that this is what you expected?

Cheers

@candlerb
Copy link
Contributor

I don't have an old instance left to compare with :-) However role and manuf/model seems reasonable to me.

@hellerve
Copy link
Contributor Author

I took the template from pre-2.6 and recreated the text. The style of course is different, but the information on it should be the same!

@jeremystretch
Copy link
Member

I don't think this fully resolves the issue, since I'd really love to support popovers with formatted text as we had in prior releases, however this works well as a temporary solution. I think it's best to close #3963 with this; I'll open a new FR for the improved popovers to be undertaken in the future. Thanks for the quick turnaround on these @hellerve!

@hellerve
Copy link
Contributor Author

Of course. I broke it, I fix it.

I also agree that the fidelity is a little low, but I think that working on improving the popovers for too long might not have the right ROI at the moment.

@jeremystretch jeremystretch merged commit 007de40 into netbox-community:develop Jan 21, 2020
@hellerve hellerve deleted the veit/fix-3963 branch January 21, 2020 16:34
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG rack elevations don’t render tooltips anymore
3 participants