Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression/Decompression Codecs should enforce memory allocation size limits #6168

Closed
Scottmitch opened this issue Dec 30, 2016 · 2 comments · Fixed by #9924
Closed

Compression/Decompression Codecs should enforce memory allocation size limits #6168

Scottmitch opened this issue Dec 30, 2016 · 2 comments · Fixed by #9924
Milestone

Comments

@Scottmitch
Copy link
Member

Expected behavior

To protect against OOME the compression and decompression codecs should explicitly limit the amount of data they compress and decompress. We may be vulnerable to OOME from large or malicious input.

Actual behavior

In light of #5997 most of the compression/decompression codecs don't enforce limits on buffer allocation sizes.

Steps to reproduce

N/A

Minimal yet complete reproducer code (or URL to code)

N/A

Netty version

4.1.7-SNAPSHOT

JVM version (e.g. java -version)

N/A

OS version (e.g. uname -a)

N/A

@Scottmitch
Copy link
Member Author

@normanmaurer @jasobrown - FYI.

@rdicroce
Copy link
Contributor

This should probably be reopened. My PR only fixes this for subclasses of ZlibDecoder; it does not fix this for any other compression algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants