Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Windows client 3.12.4 and 13.3 does not sync renamed or moved files #6721

Open
5 of 8 tasks
oxivanisher opened this issue May 1, 2024 · 23 comments
Open
5 of 8 tasks

Comments

@oxivanisher
Copy link

oxivanisher commented May 1, 2024

⚠️ Before submitting, please verify the following: ⚠️

Bug description

The Nextcloud Client does not sync changed files on Windows.

All Windows clients I use, use the Virtual Filesystem. The server does not produce a log entry during this, so I think its only client related. Also on a Linux client with 3.13, the sync works without a problem. Strangely, the client (sometimes?) shows that the file has been changed, but the upload to the server does not happen.
nextcloud_error_2

I was able to test it with a 3.12.3 windows client (also with VFS) which works as expected. After upgrading this client to 3.13, it also stopped syncing instantly. The sync can be forced by exiting and restarting the client.

Steps to reproduce

  1. Create a temp test file i.e. containing some text. On a Windows 3.13 client with VFS.
  2. Check the content within the web UI
  3. Change the content on the Windows client to something else
  4. The content will not change on the server, and the clients seems to do "nothing" / seems to work as expected
  5. Exiting and restarting the client seems to trigger the sync and the file gets changed on the server

Expected behavior

The file should be synced automatically after being changed.

Which files are affected by this bug

test.txt

Operating system

Windows

Which version of the operating system you are running.

Windows 11

Package

Appimage

Nextcloud Server version

28.0.5

Nextcloud Desktop Client version

3.13 and 3.12.4

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

The server created no error or warning messages during the two hours of testing this.

Additional info

The debug archive was way to big to upload here. Also I am not that keen on uploading a directory listing of all my files to the internet... This is the sqlite entry of the tmp/test.txt file from the .sync_*.db file:

INSERT INTO "main"."metadata" ("phash", "pathlen", "path", "inode", "uid", "gid", "mode", "modtime", "type", "md5", "fileid", "remotePerm", "filesize", "ignoredChildrenRemote", "contentChecksum", "contentChecksumTypeId", "e2eMangledName", "isE2eEncrypted", "isShared", "lastShareStateFetchedTimestmap", "sharedByMe", "lock", "lockType", "lockOwnerDisplayName", "lockOwnerId", "lockOwnerEditor", "lockTime", "lockTimeout") VALUES ('-1217135354298682854', '12', 'tmp/test.txt', '1130930', '0', '0', '0', '1714567689', '0', '02068fe69d062d487bf06261d814f2c4', '0527984351b4b9d916170', 'WDNVR', '7', '0', '843c14c6c9259eb62ab88af596c209144682a7ca', '1', '', '0', '0', '1714568128430', '0', '0', '0', '', '', '', '0', '0');

These are the logs from the client from the last hour of testing:
20240501_1444_nextcloud.log.0.gz
20240501_1443_nextcloud.log.2.gz
20240501_1443_nextcloud.log.1.gz
20240501_1443_nextcloud.log.0.gz
20240501_1450_nextcloud.log.0.gz
20240501_1445_nextcloud.log.0.gz

@ivanes82
Copy link

ivanes82 commented May 1, 2024

Same problem here, nextcloud upgraded to Nextcloud Hub 8 (29.0.0), windows client version 3.13. Modified files are not updated. Going back to version 3.12.3 fixes the problem.

@oxivanisher
Copy link
Author

oxivanisher commented May 2, 2024

I can confirm that downgrading to 3.12.4 fixes this. For anybody searching the download link, you can find it here: https://github.com/nextcloud-releases/desktop/releases/download/v3.12.4/Nextcloud-3.12.4-x64.msi

EDIT: Downgrade to 3.12.3 for a fix: https://github.com/nextcloud-releases/desktop/releases/download/v3.12.3/Nextcloud-3.12.3-x64.msi

As a comment: This bug is really bad! After downgrading, my clients went nuts about different versions of my keepass file. Fixing manually was not fun, but way worse, if one of the systems would have died, I had lost passwords... IMHO 3.13 and 3.12.4 should be removed for windows until this bug is fixed in a new version.

@diegodan1893
Copy link

diegodan1893 commented May 2, 2024

I have the same problem in Windows 10. EDIT: no, it looks like updated files are syncing correctly for me, I only see the issue when moving files between folders.

Any updates to existing files are not synced to the server. I'm seeing a similar issue when moving files between synced folders or renaming them. The file will be moved or renamed locally, but the action won't be applied in the server. In the windows explorer, the file is stuck with the syncing blue arrows forever, but the icon in the task bar will be the green checkmark and clicking the "Sync now" button won't do anything.

For me, the issue happens when the file is NOT virtual. Virtual files can't be edited, so I can't test that, but they can be moved. If the file is virtual (it has the cloud icon in Windows Explorer) moving it to a different folder will also move it in the server. The bug only happens if the file is locally available.

This issue happens in both 3.13.0 and 3.12.4.
3.12.3 is the latest version that doesn't have this bug.

@ivanes82
Copy link

ivanes82 commented May 2, 2024

I have tried version 3.12.4 and for me it still has the error. It does not update the files when they change.

@oxivanisher
Copy link
Author

This seems to be even more complex. I tried to find out how long it takes for the files to be changed (using 3.12.4). I changed the file on the windows machine and then check the content of the file on a linux system via mounted webdav in a loop to measure roughly seconds. For the first ~8 changes it took between 45 and 80 seconds ... and then it stopped updating completely.

So this is really unpredictable and this might be the reason why it works for some people on some version and not for others. I might test different versions to find out which version really did work all the time.

Also I can confirm the problem with moving files as described by @diegodan1893

@oxivanisher
Copy link
Author

It is VERY clear when the problem was introduced. 😂 As @diegodan1893 and @ivanes82 said, the last working version is 3.12.3.

With 3.12.4

$ ./check_nextcloud_delay.sh
Starting to measure Nextcloud delay
Content updated after 37 seconds (random delay was: 9)
Content updated after 57 seconds (random delay was: 3)
Content updated after 50 seconds (random delay was: 9)
Content updated after 53 seconds (random delay was: 7)
Content updated after 51 seconds (random delay was: 9)
Content updated after 53 seconds (random delay was: 8)
Content updated after 51 seconds (random delay was: 9)
Content update took more than 3 minutes, exiting

Starting to measure Nextcloud delay
Content updated after 51 seconds (random delay was: 9)
Content updated after 58 seconds (random delay was: 1)
Content updated after 54 seconds (random delay was: 4)
Content updated after 54 seconds (random delay was: 8)
Content update took more than 3 minutes, exiting

With 3.12.3

$ ./check_nextcloud_delay.sh
Starting to measure Nextcloud delay
Content updated after 4 seconds (random delay was: 2)
Content updated after 5 seconds (random delay was: 4)
Content updated after 4 seconds (random delay was: 7)
Content updated after 5 seconds (random delay was: 6)
Content updated after 4 seconds (random delay was: 7)
Content updated after 3 seconds (random delay was: 0)
Content updated after 5 seconds (random delay was: 1)
Content updated after 4 seconds (random delay was: 9)
Content updated after 4 seconds (random delay was: 2)
Content updated after 5 seconds (random delay was: 7)
Content updated after 5 seconds (random delay was: 6)
Content updated after 4 seconds (random delay was: 6)
Content updated after 3 seconds (random delay was: 0)
Content updated after 4 seconds (random delay was: 8)
Content updated after 4 seconds (random delay was: 2)
Content updated after 3 seconds (random delay was: 8)
Content updated after 3 seconds (random delay was: 5)
Content updated after 5 seconds (random delay was: 5)
Content updated after 4 seconds (random delay was: 2)
Content updated after 3 seconds (random delay was: 1)
Content updated after 5 seconds (random delay was: 6)
Content updated after 4 seconds (random delay was: 9)
Content updated after 4 seconds (random delay was: 8)
Content updated after 5 seconds (random delay was: 9)
Content updated after 3 seconds (random delay was: 0)
Content updated after 57 seconds (random delay was: 0)
Content updated after 4 seconds (random delay was: 1)
Content updated after 3 seconds (random delay was: 4)
Content updated after 3 seconds (random delay was: 7)
Content updated after 4 seconds (random delay was: 8)
Content updated after 56 seconds (random delay was: 0)
Content updated after 4 seconds (random delay was: 1)
Content updated after 3 seconds (random delay was: 4)
Content updated after 3 seconds (random delay was: 2)
Content updated after 5 seconds (random delay was: 4)
Content updated after 3 seconds (random delay was: 6)
Content updated after 6 seconds (random delay was: 3)
Content updated after 3 seconds (random delay was: 4)
Content updated after 3 seconds (random delay was: 2)
Content updated after 5 seconds (random delay was: 5)
Content updated after 3 seconds (random delay was: 0)
Content updated after 5 seconds (random delay was: 2)
Content updated after 4 seconds (random delay was: 4)
Content updated after 4 seconds (random delay was: 5)
Content updated after 3 seconds (random delay was: 0)
Content updated after 5 seconds (random delay was: 5)
Content updated after 4 seconds (random delay was: 8)
Content updated after 5 seconds (random delay was: 1)
Content updated after 4 seconds (random delay was: 8)
Content updated after 3 seconds (random delay was: 3)
Content updated after 37 seconds (random delay was: 0)
Content updated after 3 seconds (random delay was: 6)
Content updated after 5 seconds (random delay was: 2)
Content updated after 4 seconds (random delay was: 4)
Content updated after 3 seconds (random delay was: 6)
# stopped it manually

@oxivanisher oxivanisher changed the title [Bug]: Windows client 3.13 (probably with virtual fileystem) does not sync changed files [Bug]: Windows client 3.12.4 and 13.3 (probably with virtual fileystem) does not sync changed files May 3, 2024
@oxivanisher oxivanisher changed the title [Bug]: Windows client 3.12.4 and 13.3 (probably with virtual fileystem) does not sync changed files [Bug]: Windows client 3.12.4 and 13.3 ~~(probably with virtual fileystem)~~ does not sync changed files May 3, 2024
@oxivanisher oxivanisher changed the title [Bug]: Windows client 3.12.4 and 13.3 ~~(probably with virtual fileystem)~~ does not sync changed files [Bug]: Windows client 3.12.4 and 13.3 (probably with virtual fileystem) does not sync changed files May 3, 2024
@PasswordIs0000
Copy link

I can confirm. Had the same problem with 3.13.0 and now after a downgrade to 3.12.3 it works perfectly fine.

@JeremyJava
Copy link

My wife and I have identical win10 laptops except mine way more memory, and Win 10 Home version. Hers is Win10 Pro version. Both Windows client 13.3. Hers has no problem. Mine, when I rename a file or move it, the syncing icon is perpetual, the file is effectively disconnected from nextcloud which thinks sync was successful. Force sync does nothing and the same symptoms continue.
IMHO the desktop client is not parsing the path/filename correctly and does not notice it has changed on my laptop.

Is my windows Home version an issue by not setting a flag allowing outside control, and the 12.4 and 13.3 client uses this flag?

I am terrified to degrade to 12.3 based on oxivanisher's experience. My symptoms are consistent enough that I will stick with workaround until this is figured out.

@diegodan1893
Copy link

diegodan1893 commented May 6, 2024

I am terrified to degrade to 12.3 based on oxivanisher's experience. My symptoms are consistent enough that I will stick with workaround until this is figured out.

I didn't have any issues downgrading. If you only experienced issues when moving or renaming files, it should be fine.

Also, I'm in Windows 10 Pro, so I don't think is a Home version issue.

@oxivanisher
Copy link
Author

@JeremyJava I also think you should be ok downgrading your clients. My problems with the keepass files was because the clients did not sync and the files went "out of sync". Downgrading only showed the problem, but it already existed because of the new client.

@PhilippSchlesinger
Copy link

I can confirm the issue with 3.12.4 and that downgrading to 3.12.3 resolves the issue.
Could anyone test if the issue is still present in 3.12.5?

@vagner-dias
Copy link

I am using V3.13.0 + NC 28.0.3 and the problem persists.

I can rename VFS files with no issues but if I try to rename a synchronized file, the client does not rename it on the server and all subsequent changes get stuck.

@mgallien - can you please assist? I do have a bunch of users complaining of the same issue.

@mrtumnus
Copy link

mrtumnus commented May 10, 2024

I think I've experienced this while renaming files. Everything I rename ends up as pending and does not sync. This was a major issue yesterday when I was trying to batch rename a bunch of pictures, but then they didn't sync!

I'm using Nextcloud 3.13.0.20240423 on Windows 10 22H2.

EDIT: Also confirming that downgrade to 3.12.3 resolves the sync issues.

@Danteba
Copy link

Danteba commented May 10, 2024

Yes the problem seems to be related to renaming and moving. A new file in the folder syncs ok.

@ristein
Copy link

ristein commented May 13, 2024

Edits to a textfile do not reach the server although sync client says I changed it. Going to settings and clicking "Force sync now" helps as a workaround without needing to restart sync client.
Problem seems only to be with .txt-files, as others are getting synced instantly.
Downgraded, working now.

@PhilippSchlesinger
Copy link

PhilippSchlesinger commented May 17, 2024

Could anyone test if the issue is still present in 3.12.5?

Did anyone find that out already?

@vagner-dias
Copy link

Could anyone test if the issue is still present in 3.12.5?

Did anyone find that out already?

I have tested 3.12.5 today and it has the same problem. The latest version not presenting this issue is 3.12.3

@vagner-dias
Copy link

I am having the same issue here using the Desktop Client V3.13.0 + NC 28.0.3

My logs after trying to rename a file:

2024-05-15 09:28:34:256 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:34:586 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:34:759 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:34:884 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:35:026 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:35:168 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:35:278 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:39:465 [ info nextcloud.gui.folder.manager C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\folderman.cpp:959 ]:	Etag poll timer timeout
2024-05-15 09:28:39:465 [ info nextcloud.gui.folder.manager C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\folderman.cpp:963 ]:	Folders to sync: 1
2024-05-15 09:28:39:465 [ info nextcloud.gui.folder.manager C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\folderman.cpp:973 ]:	Number of folders that don't use push notifications: 0
2024-05-15 09:28:52:405 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:52:515 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:52:673 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:28:52:783 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:29:01:512 [ warning qt.qpa.mime unknown:0 ]:	Retrying to obtain clipboard.
2024-05-15 09:29:05:419 [ info nextcloud.gui.account.state C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\accountstate.cpp:566 ]:	Skipping server availability check for account [HIDDEN] with state 2
2024-05-15 09:29:09:470 [ info nextcloud.gui.folder.manager C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\folderman.cpp:959 ]:	Etag poll timer timeout
2024-05-15 09:29:09:470 [ info nextcloud.gui.folder.manager C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\folderman.cpp:963 ]:	Folders to sync: 1
2024-05-15 09:29:09:470 [ info nextcloud.gui.folder.manager C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\folderman.cpp:973 ]:	Number of folders that don't use push notifications: 0
2024-05-15 09:29:29:036 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:29:29:145 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:29:29:271 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:29:29:397 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:29:29:523 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"
2024-05-15 09:29:29:649 [ warning nextcloud.gui.shellextensions.server C:\Users\User\AppData\Local\Temp\windows-22489\client-building\desktop\src\gui\shellextensionsserver.cpp:108 ]:	Record not found in SyncJournal for:  "Check_This_Folder/check_this_file_001_003.txt"

@Castiontone
Copy link

Confirm that bug persists in every iteration of the desktop client after 3.12.3

NC 28.0.5
Windows 11
Desktop Client above V3.12.3
VFS enabled

@Castiontone
Copy link

What about these backports of last month: #6621 #6606

Both influence whether changes in files (VFS) are synced to the server

@Castiontone
Copy link

Castiontone commented May 23, 2024

So this already solved earlier. And reintroduced?

https://help.nextcloud.com/t/nc-client-3-12-0-not-recognizing-file-renaming-in-windows/183635

@diegodan1893
Copy link

diegodan1893 commented May 24, 2024

@oxivanisher can you rename this isue to "Windows client 3.12.4 and 13.3 does not sync renamed or moved files"? Since now we know that moving/renaming the file is what triggers the bug. Otherwise the developers have to read the comments to know what the bug is about, maybe that's the reason this is still in "needs triage".
Maybe add "regression" somewhere in the title too, since this was a bug that was already fixed but reappeared in the next update.

@oxivanisher oxivanisher changed the title [Bug]: Windows client 3.12.4 and 13.3 (probably with virtual fileystem) does not sync changed files [Bug]: Windows client 3.12.4 and 13.3 does not sync renamed or moved files May 24, 2024
@oxivanisher
Copy link
Author

@oxivanisher can you rename this isue to "Windows client 3.12.4 and 13.3 does not sync renamed or moved files"? Since now we know that moving/renaming the file is what triggers the bug. Otherwise the developers have to read the comments to know what the bug is about, maybe that's the reason this is still in "needs triage". Maybe add "regression" somewhere in the title too, since this was a bug that was already fixed but reappeared in the next update.

Sure and done. Let's hope somebody reads this ... its a really bad bug!
But I am not sure that this title is more correct. For me, it did not sync new files with changed content. Nothing to do with moved or renamed files. This is in addition IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests