Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no longer override the pixman default version #5630

Merged
merged 1 commit into from Apr 27, 2023
Merged

no longer override the pixman default version #5630

merged 1 commit into from Apr 27, 2023

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien @allexzander
no longer override the pixman default version
1a352d8 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5630-1a352d8629e378086f8932766f4fb8e828f5bf0a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited

Codecov Report

Merging #5630 (1a352d8) into master (38ae92b) will decrease coverage by 0.03%.
The diff coverage is 39.53%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5630      +/-   ##
==========================================
- Coverage   59.28%   59.26%   -0.03%     
==========================================
  Files         143      143              
  Lines       18445    18455      +10     
==========================================
+ Hits        10936    10937       +1     
- Misses       7509     7518       +9
Impacted Files Coverage Δ
src/libsync/logger.h 61.53% <ø> (ø)
src/libsync/logger.cpp 28.57% <35.00%> (+0.41%) ⬆️
src/common/syncjournaldb.cpp 78.72% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien merged commit 13916df into master Apr 27, 2023
11 of 13 checks passed
@mgallien mgallien deleted the ci/fiwWindowsBuilds branch April 27, 2023 15:21
@mgallien
Copy link
Collaborator Author

/backport to stable-3.8

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 27, 2023
Merged
@mgallien mgallien added this to the 3.9.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mgallien @nextcloud-desktop-bot @allexzander @claucambra