Fix rm path for update package #1625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve docker compatibility: Change the backup directory for ./nextcloud/data to reside within the host file system (basedir) so as to avoid moving the data folder back and forth between the docker container and the host file system. In situations where the nextcloud data takes up more than the free available space on the host system, this may lead to loosing some or all of the data. Signed-off-by: MB-Finski <64466176+MB-Finski@users.noreply.github.com>
Improves docker compatibility. Placing the backup file in /var/www/ will cause a failure in rolling back the update on containerized setups ("Can only restore from ext/btrfs/zfs filesystems"). The host filesystem is most likely compatible so using $BASEDIR as the backup location *should* solve this issue for most users.
Signed-off-by: MB-Finski <64466176+MB-Finski@users.noreply.github.com>
Change backup directory for docker compatibility
Fixes a bening bug where the nextcloud update package won't be removed after unpacking when the code is run inside a docker container. Also, for readability/clarity, remove an unnecessary "/var/www" from a cp command. Signed-off-by: MB-Finski <64466176+MB-Finski@users.noreply.github.com>
theCalcaholic
force-pushed
the
devel
branch
4 times, most recently
from
8d181e6
to
d9cb654
Compare
theCalcaholic
force-pushed
the
devel
branch
5 times, most recently
from
dce6a9f
to
cdf99f6
Compare
theCalcaholic
force-pushed
the
devel
branch
2 times, most recently
from
ec7a07e
to
9ed15a5
Compare
theCalcaholic
force-pushed
the
devel
branch
9 times, most recently
from
3b1e437
to
b84e2d8
Compare
theCalcaholic
force-pushed
the
devel
branch
30 times, most recently
from
a5cf782
to
8c1dc9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bening bug where the nextcloud update package won't be removed after unpacking when the code is run inside a docker container.
Also, for readability/clarity, remove an unnecessary "/var/www" from a cp command.
Edit: As a side note, the ncp-update-nc script uses absolute and relative path references variably. Absolute references using either $BASEDIR or $DATADIR would perhaps make the script more robust and future proof. Would such a commit/pull request make sense?
Signed-off-by: MB-Finski 64466176+MB-Finski@users.noreply.github.com