[wip] feat: welcome typescript and cypress in docker #4237
Conversation
|
Thanks a lot for looking into this @skjnldsv ! |
max-nextcloud
force-pushed
the
feat/cypress-ts
branch
from
35f44b1
to
aaac274
Compare
|
|
||
| // Before the browser launches | ||
| // starting Nextcloud testing container | ||
| return startNextcloud(process.env.BRANCH) |
There was a problem hiding this comment.
Would be nice to have an option to still run this towards a local instance for easier debugging. And the currently used docker image doesn't come with arm architecture support.
There was a problem hiding this comment.
Do we support arm officially?
There was a problem hiding this comment.
Depends on what you mean with supporting, at least community has high demand with single board computers.
Also this would block developers on apple arm chips from running the tests in a reasonable time.
There was a problem hiding this comment.
At least providing a way to just pass CYPRESS_baseUrl as an environment variable and then not setup docker would be nice, but I can look into that part :)
There was a problem hiding this comment.
Well, I'm guessing the current behaviour also breaks on windows.
I think it's an interesting topic, but I don't think it's worth spending more time on it. 🙈
There was a problem hiding this comment.
Yes, Hephi2 had problems running the server tests on windows as well with WSL+Docker. Let's go for the manual URL approach then as a fallback/workaround which should be easy to add
| await runExec(container, ['php', 'occ', 'config:system:set', 'force_language', '--value', 'en'], true) | ||
| await runExec(container, ['php', 'occ', 'config:system:set', 'default_locale', '--value', 'en_US'], true) | ||
| await runExec(container, ['php', 'occ', 'config:system:set', 'force_locale', '--value', 'en_US'], true) | ||
| await runExec(container, ['php', 'occ', 'config:system:set', 'enforce_theme', '--value', 'light'], true) |
There was a problem hiding this comment.
Ideally also have "memcache.local"=>"\OC\Memcache\APCu","hashing_default_password"=>true for faster runs
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
juliushaertl
force-pushed
the
feat/cypress-ts
branch
from
aaac274
to
7cd1ae4
Compare
Ongoing effort, some adjustments might be needed 😉
Please take over Text team! 🚀