-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request the native app to reload the direct editing view on 403 errors #5662
base: main
Are you sure you want to change the base?
Conversation
Hey @nicofrand Thanks a lot for your PR. There are different scenarios which may cause a 403:
In the case of an expired session reconnecting should fix the connection. But that's not what's happening right now i guess. Will need to investigate.
I think displaying a message that asks for reloading the page would be a good start. We already do that in some cases.
You should be able to check |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Hi! Thanks for your comments.
OK but the 403 occurs in the SyncService, which does not have access to
Could you explain how to test a DirectEdition outside the android app? I was not able to find a way… |
📝 Summary
When it receives a 403 error it triggers a reload event, catchable by the android app.
Warning
I don't know how this app works/should behave in some cases, and this PR needs discussion.