Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding authentication via JSON REST API #134

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

msfuture
Copy link

@msfuture msfuture commented Apr 2, 2020

Changes proposed in this pull request:

  • adding REST JSON API for external user authentication:
  • checks REST endpoint and gets optional and additional user data like groups and displayname

Signed-off-by: Michael E. Schindler <mail@msfuture.de>
Signed-off-by: Michael E. Schindler <mail@msfuture.de>
@violoncelloCH
Copy link
Member

thanks for your contribution @msfuture
I'll take a closer look at it as soon as I find the time to do so...

@violoncelloCH violoncelloCH added 3. to review enhancement New feature or request labels Apr 10, 2020
@violoncelloCH violoncelloCH self-requested a review April 10, 2020 15:04
@msfuture
Copy link
Author

msfuture commented Apr 20, 2020

By the way: I'm already testing this type of authentication with about 400 accounts involved. No errors and automatical group assignment made life so much easier for my colleagues.

Signed-off-by: Michael E. Schindler <mail@msfuture.de>
@kesselb
Copy link

kesselb commented May 10, 2020

There is a wrapper for Guzzle and Curl: IClient (and IClientService as factory`). An advantage is that a proxy configuration (at config.php) is automatically used.

@violoncelloCH
Copy link
Member

thanks for the hint @kesselb !
so that should definitely be used (also by the other backends)... @msfuture could you take a look at this?
https://github.com/nextcloud/server/blob/master/lib/private/Http/Client/Client.php

@msfuture
Copy link
Author

I'll take a look at this!

Signed-off-by: Michael E. Schindler <mail@msfuture.de>
@msfuture
Copy link
Author

Time went by so fast... But I finally got to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants