Ultimate Fix Proposal: Vendor CSS issue during build & compile #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there are a bunch discussions about issues relevant to organizing vendor CSS via grunt build & compile tasks but all PRs as far as I can see did not get the point and makes the situation worse.
Thus I raised this PR. Should be able to solve issues mentioned in
#340
#305
67739b8
My PR is implemented based on discussion in #185
As far as I know the correct way of loading external Vendor CSS is that
we define it in build.config.js->vender_files->css (other than
explicitly import it in main.less, etc); however there is something
wrong with loading vendor css via grunt tasks in commit
268901b.
Weird Behavior before this fix:
build
'copy:compile_assets' task simply copies concatenated all-in-one css
file from build folder
Current Behavior after this fix:
standalone reference in index.html to vendor CSS copied to its vendor
folder
regardless of whether build task has been performed
The modification has been tested under following cases:
Still, please kindly notice:
they are not relevant in build
From personal point of view I would not support following PRs, which did not suffice to be merged in the main branch:
re-concat CSS files when LESS files change #369
add concatenating css on less change #390
still partially depends on build task for javascript files in src/ while
all vendor files (incl. CSS, JS) can be compiled successfully all the
time. This is due to historical reasons that 'ngAnnotate' and
'concat:compile_js' loads file from build folder. As I'm quite unsure if
there exists modification during the process of copying those relevant
app js from original src to build, I just leave it remained as for now.