Fix regexpr search for upper case strings #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I broke the regexpr search for upper case strings earlier. The problem was that REG_ICASE was not passed to regcomp and friends, only regexec, which resulted in no match on glibc. Fix this here. Also make sure that regexpr options that do not support case insensitive matching always use the "always convert" slow path. Also fixes an obscure compiling problem with some ifdef configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke the regexpr search for upper case strings earlier. The problem
was that REG_ICASE was not passed to regcomp and friends, only
regexec, which resulted in no match on glibc.
Fix this here. Also make sure that regexpr options that do not support
case insensitive matching always use the "always convert" slow path.
Also fixes an obscure compiling problem with some ifdef configuration.