Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sanitizer #1670

Merged
merged 4 commits into from Jul 14, 2021
Merged

fix: sanitizer #1670

merged 4 commits into from Jul 14, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Jul 12, 2021

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

adhrinae
adhrinae approved these changes Jul 13, 2021
View reviewed changes
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

lja1018
lja1018 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

apps/editor/src/__test__/unit/sanitizer.spec.ts Outdated Show resolved Hide resolved
@js87zz js87zz merged commit 48a01f5 into master Jul 14, 2021
@js87zz js87zz deleted the fix/sanitizer branch July 14, 2021 06:37
@phith0n phith0n mentioned this pull request Jul 31, 2021
Closed
@wadiz-seoyeon-yeom wadiz-seoyeon-yeom mentioned this pull request Sep 26, 2022
Open
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
fix: sanitizer (nhn#1670)
17858d6 
* fix: sanitize onload event attr

* chore: add test case(sanitizer)

* chore: remove unnecessary comment

* chore: apply code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhrinae adhrinae adhrinae approved these changes

@lja1018 lja1018 lja1018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@js87zz @adhrinae @lja1018