unsigned values can't be less than 0

nickgammon · Mar 11, 2016 · f425baa · f425baa
1 parent 120b5b6
commit f425baa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/luacom/tCOMUtil.cpp b/luacom/tCOMUtil.cpp
@@ -367,9 +367,8 @@ ITypeLib* tCOMUtil::LoadTypeLibFromProgID(const char* ProgID,
     return NULL;
 
   bool version_found = false;
-  int version = -1;
 
-  if(major_version <= 0)
+  if(major_version == 0)
   {
     if(sscanf(ProgID, "%*s.%*s.%d", &major_version) == 1)
       version_found = true;
@@ -497,8 +496,7 @@ ITypeLib* tCOMUtil::LoadTypeLibFromCLSID(CLSID clsid,
 
   if(major_version > 0 &&
       (
-        (!version_info_found) ||
-        (version_info_found && found == 0)
+        (!version_info_found) || (found == 0)
       )
     )
   {
@@ -707,7 +705,6 @@ bool tCOMUtil::DelRegKey(const char *key,
                          const char *subkey)
 {
 
-  bool ok = false;
   LONG ec = 0;
 
   const int bufsize = 10000;

diff --git a/luacom/tLuaVector.cpp b/luacom/tLuaVector.cpp
@@ -50,7 +50,7 @@ unsigned long tLuaVector::get_Dimensions()
 unsigned long tLuaVector::get_Nth_Dimension(unsigned long n)
 {
   // precond
-  CHECKPRECOND(length >= 0 && n >= 0 && (n == 1 || elem_type == VECTOR));
+  CHECKPRECOND(n == 1 || elem_type == VECTOR);
 
   if(n == 1)
     return length;
@@ -323,7 +323,7 @@ void tLuaVector::InitVectorFromTable(lua_State* L, stkIndex table)
     // Itera em tabela ou userdata, criando LuaVectors recursivamente
     while(1)
     {
-      CHECKPRECOND((length <= 0 || elem_type != UNKNOWN) &&
+      CHECKPRECOND((elem_type != UNKNOWN) &&
          (length != 0 || elem_type == UNKNOWN));
 
       lua_pushvalue(L, table);