add test

i18n/bundle_test.go

@@ -131,7 +131,7 @@ simple: simple translation
 
 # Comment
 detail:
-  description: detail description 
+  description: detail description
   other: detail translation
 
 # Comment
@@ -150,6 +150,47 @@ everything:
 	expectMessage(t, bundle, language.AmericanEnglish, "everything", everythingMessage)
 }
 
+func TestInvalidYAML(t *testing.T) {
+	bundle := NewBundle(language.English)
+	bundle.RegisterUnmarshalFunc("yaml", yaml.Unmarshal)
+	_, err := bundle.ParseMessageFileBytes([]byte(`
+# Comment
+simple: simple translation
+
+# Comment
+detail:
+  description: detail description
+  other: detail translation
+
+# Comment
+everything:
+  description: everything description
+  zero: zero translation
+  one: one translation
+  two: two translation
+  few: few translation
+  many: many translation
+  other: other translation
+  garbage: something
+
+description: translation
+`), "en-US.yaml")
+
+	expectedErr := &mixedKeysError{
+		reservedKeys:   []string{"description"},
+		unreservedKeys: []string{"detail", "everything", "simple"},
+	}
+	if err == nil {
+		t.Fatalf("expected error %#v; got nil", expectedErr)
+	}
+	if err.Error() != expectedErr.Error() {
+		t.Fatalf("expected error %q; got %q", expectedErr, err)
+	}
+	if c := len(bundle.messageTemplates); c > 0 {
+		t.Fatalf("expected no message templates in bundle; got %d", c)
+	}
+}
+
 func TestTOML(t *testing.T) {
 	bundle := NewBundle(language.English)
 	bundle.RegisterUnmarshalFunc("toml", toml.Unmarshal)

i18n/message.go

@@ -2,6 +2,7 @@ package i18n
 
 import (
 	"fmt"
+	"slices"
 	"strings"
 )
 
@@ -233,7 +234,6 @@ func isMessage(v interface{}) (bool, error) {
 					unreservedKeys = append(unreservedKeys, k)
 				}
 			}
-			// return false, fmt.Errorf("reserved keys %v mixed with unreserved keys %v", reservedKeys, unreservedKeys)
 			return false, &mixedKeysError{
 				reservedKeys:   reservedKeys,
 				unreservedKeys: unreservedKeys,
@@ -264,7 +264,6 @@ func isMessage(v interface{}) (bool, error) {
 					unreservedKeys = append(unreservedKeys, k)
 				}
 			}
-			// return false, fmt.Errorf("reserved keys %v mixed with unreserved keys %v", reservedKeys, unreservedKeys)
 			return false, &mixedKeysError{
 				reservedKeys:   reservedKeys,
 				unreservedKeys: unreservedKeys,
@@ -281,5 +280,7 @@ type mixedKeysError struct {
 }
 
 func (e *mixedKeysError) Error() string {
+	slices.Sort(e.reservedKeys)
+	slices.Sort(e.unreservedKeys)
 	return fmt.Sprintf("reserved keys %v mixed with unreserved keys %v", e.reservedKeys, e.unreservedKeys)
 }