Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Issue#212: Adding more machine translation alternatives #247

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rupeshkumaar
Copy link

I have worked on #212: Adding more machine translation alternatives (Glosbe & Wikimedia MinT)
Please review and merge: @nidhaloff

Copy link
Owner

@nidhaloff nidhaloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I added some comments.
Also can you please add the new translators on the README

deep_translator/glosbe.py Outdated Show resolved Hide resolved
deep_translator/glosbe.py Show resolved Hide resolved
deep_translator/mint.py Outdated Show resolved Hide resolved
deep_translator/mint.py Outdated Show resolved Hide resolved
@nidhaloff nidhaloff added the enhancement New feature or request label Oct 28, 2023
@rupeshkumaar
Copy link
Author

Added the translations to README.

@nidhaloff
Copy link
Owner

@rupeshkumaar I approved your PR but The tests are failing. Can you check it out or maybe rebase/merge your branch with the latest of master

@rupeshkumaar
Copy link
Author

@rupeshkumaar I approved your PR but The tests are failing. Can you check it out or maybe rebase/merge your branch with the latest of master

@nidhaloff the branch is up to date with the master branch. So, it does not seem to do anything with that. It said poetry installation failed in one of the tests. Can you please check that?

@rupeshkumaar
Copy link
Author

Please review now and merge @nidhaloff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants