Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libnotify bubbles for various things, get rid of pop-up approval window #16

Open
sandyarmstrong opened this issue Nov 21, 2009 · 1 comment

Comments

@sandyarmstrong
Copy link

I want libnotify bubbles when:

  • An "always approved" (see issue 15) contact connects to me
  • A contact's library (to which I am connected) disappears for whatever reason, especially if I'm currently downloading/streaming from them
  • There is a new connection approval request

This last case is the biggest change. I do not like the pop-up window. It shows up out of nowhere, and if I'm currently typing I can easily accidentally press a key to dismiss it before I even realize it's there. I would assume that most users have Banshee running in the background in some way (behind the current app window, or minimized, or on a different desktop). The chances of Banshee being their active window is super-low, so the pop-up is a HUGE flow interrupter. It should be replaced with a libnotify bubble.

When using a notification daemon that supports actions (everybody but Ubuntu), there should be buttons in the bubble to approve or deny. When using a notification daemon that does not support actions, clicking the notification should bring Banshee to the front.

Regardless of notification daemon, a yellow infobar thingy (like in Firefox) should slide into the Banshee UI with the same information as the notification bubble. This is a nice UI if you are already actively using Banshee or if you choose to ignore the bubbles at first. There should be a bar for each pending request, and it should include the approve/deny buttons. Obviously that may not scale for dozens of requests, so this might not be the perfect UI either.

Still, by no means should you be interrupted in your work/play/porn because a contact wants to browse your library. Their need cannot be as desperate as yours.

@nloko
Copy link
Owner

nloko commented Mar 7, 2010

I've done some work on this. It's in a semi-finished state--or maybe even finished. I'm using libnotify bubbles and a Banshee source status message with buttons. Also, the contact source will pulse every 5 seconds to let you know that something needs attention. Much less intrusive.

I figure that users will be on Empathy anyway. And, if they want to poke someone about a request, they will just message them about it. Banshee does not need to get obnoxious about letting the user know about a request.

Just merged it into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants