fix: res.requestUrls should be string array (#271)

node-modules · Dec 29, 2017 · e3df75e · e3df75e
1 parent 2051273
commit e3df75e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/urllib.js b/lib/urllib.js
@@ -541,7 +541,7 @@ exports.requestWithCallback = function requestWithCallback(url, args, callback)
   debug('Request#%d %s %s with headers %j, options.path: %s',
     reqId, method, url, options.headers, options.path);
 
-  args.requestUrls.push(url);
+  args.requestUrls.push(parsedUrl.href);
 
   function onResponse(res) {
     if (timing) {

diff --git a/test/urllib.test.js b/test/urllib.test.js
@@ -1448,7 +1448,7 @@ describe('test/urllib.test.js', function () {
       });
     });
 
-    it('should listen request url, when request url is object', function (done) {
+    it('should listen request url is string, when request url is object', function (done) {
       done = pedding(3, done);
       var requestUrl = 'https://cn.bing.com/search?q=nodejs';
 
@@ -1459,6 +1459,7 @@ describe('test/urllib.test.js', function () {
 
       urllib.on('response', function (info) {
         assert(info.req.url === requestUrl);
+        assert(info.res.requestUrls[0] === requestUrl);
         done();
       });