New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass full error object in Function node and copy over cause property #4685

Merged

knolleary merged 2 commits into master from 4683-preserve-full-error-obj

May 13, 2024

Member

knolleary commented May 9, 2024

Fixes #4683

This does two things around error handling

preserves the cause property of any Error object passed to node.error(...). This is a standard property of Error so reasonable to copy over.
updates Function node error handling to pass up the whole error object, not just the message string

The results of this will mean if an error thrown in a Function node includes a cause property it will be present on the message sent by a Catch node.

knolleary added 2 commits

May 9, 2024 16:48


          Pass full error object in Function node and copy over cause property

66a667f

Fixes #4683


          Update tests for changed function node low-level output

03648dc

knolleary merged commit f55ee6e into master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment