Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): increase required node >=18.5 #4690

Merged
merged 1 commit into from May 14, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented May 12, 2024

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Test statement can be simplified by increasing the required minor version. Earlier node version seem buggy.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Reference

#4687

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to update packages/node_modules/node-red/package.json to match

Statement can be simplified by increasing the required minor version.
@knolleary knolleary merged commit ac6a494 into node-red:dev May 14, 2024
3 checks passed
@Rotzbua Rotzbua deleted the fix_node_requirement branch May 14, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants