Skip to content

Commit

Permalink
process_wrap: omit superfluous Number creation
Browse files Browse the repository at this point in the history
Don't create a superfluous Number object, just use the version of
v8::Object::Get() that takes an unsigned int. Convert the index to
unsigned int while we're here.
  • Loading branch information
bnoordhuis committed Aug 6, 2013
1 parent 45d056e commit b8a7eed
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/process_wrap.cc
Expand Up @@ -86,13 +86,12 @@ class ProcessWrap : public HandleWrap {
uv_process_options_t* options) {
Local<Array> stdios = js_options
->Get(String::NewSymbol("stdio")).As<Array>();
int len = stdios->Length();
uint32_t len = stdios->Length();
options->stdio = new uv_stdio_container_t[len];
options->stdio_count = len;

for (int i = 0; i < len; i++) {
Local<Object> stdio = stdios
->Get(Number::New(static_cast<double>(i))).As<Object>();
for (uint32_t i = 0; i < len; i++) {
Local<Object> stdio = stdios->Get(i).As<Object>();
Local<Value> type = stdio->Get(String::NewSymbol("type"));

if (type->Equals(String::NewSymbol("ignore"))) {
Expand Down

0 comments on commit b8a7eed

Please sign in to comment.