Add new cidr const and remove dep on network fact #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since chrony is set up in kickstart we can not use network facts based on named_interfaces.
This fix makes sure chronyd do not fail to start on first boot.
A new constant pr region is introduced, "netcfg_trp_cidr4". The constant is simply the IPv4 netmask in the standard CIDR notation. Normally, we calculate this value based on the traditional netmask value, but this is not possible in every usecase, including configuration of chrony on controllers in the kickstart phase.
These changes are meant as a replacement for PR
#893