Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim Lighline Colors for Inactive Window #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

husainaloos
Copy link

Reversed the colors of lightline status bar of the inactive window. This
helps with knowing immediately which window is active. Otherwise, it
is hard to tell from the colors which window is active and which is
inactive.

Reversed the colors of lightline status bar of the inactive window. This
helps with knowing immediately which window is active. Otherwise, it
is hard to tell from the colors which window is active and which is
inactive.
@husainaloos
Copy link
Author

before:

before_nord

after:
after_nord

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Nov 28, 2019

Hi @husainaloos 👋, thanks for your contribution 👍

In my opinion it's harder to distinguish between the different split panes/windows when the background color of the outer left element is the same like for inactive status bars. The difference between the active and inactive panes/windows can be recognized by the background color of the status bar (that can also be configured) as well as the additional mode block next to the file name.

I'd suggest this change should be better made on your side by customizing the lightline to fit your needs.

@husainaloos
Copy link
Author

@arcticicestudio Thanks for the feedback.

I find it hard to distinguish the active/non-active panel because the status bar looks very similar in both cases. In the first screenshot, it is not clear immediately which panel is active, and one has to slow down and read the status bar to find out.

Your concerns, on the other hand, are fair as well. It is indeed slightly difficult to identify the panels in the second screenshot.

Do you have any recommended changes for my case?

@svengreb
Copy link
Member

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to for triage in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@husainaloos Thank you for your patience and again for your contribution at all! 🙏🏼
Currently the only way to do it is to modify the lightline.vim theme code itself. You can change colors on your machine, but remember that it will be overridden (or even cause merge conflicts) when you update the Nord plugin to newer versions (or Git references).
A fully customizable lightline.vim theme is planned like already submitted in #124 for vim-airline. Feel free to submit a pull request or wait until the tasks gets planned in for one of the next iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants