Issues - norman/friendly_id

norman / friendly_id

584

Description:

FriendlyId is the “Swiss Army bulldozer” of slugging and permalink plugins for ActiveRecord. It allows you to create pretty URL’s and work with human-friendly strings as if they were numeric ids for ActiveRecord models.

Sort by: Priority | Votes | Last Updated

Loading…

7.

1 vote

Reserved words in sluggable models
2 comments Created about 1 month ago by cypok

Title

Body
"For sluggable models, if such a word is used, it will be treated the same as if that slug was already taken (numeric extension will be appended). Defaults to ["new", "index"]." But when I try to create object with name 'new' I got an exception "The slug text is a reserved value" ??
or cancel

"For sluggable models, if such a word is used, it will be treated the same as if that slug was already taken (numeric extension will be appended). Defaults to ["new", "index"]." But when I try to create object with name 'new' I got an exception "The slug text is a reserved value" ??

Comments

norman Fri Sep 25 06:01:07 -0700 2009 | link

I think this is an example of DDD ("documentation driven development") gone awry. I probably documented this feature in a branch before adding it, and then ended up implementing it differently. Until now nobody has called me on it, and I never noticed it.

I will get a fix in place soon so that the feature actually matches what it says in the docs.

Comment
I think this is an example of DDD ("documentation driven development") gone awry. I probably documented this feature in a branch before adding it, and then ended up implementing it differently. Until now nobody has called me on it, and I never noticed it. I will get a fix in place soon so that the feature actually matches what it says in the docs.
or cancel

cypok Fri Sep 25 11:30:31 -0700 2009 | link

Thank you! Please write here, when I'll done it so I could update you great plugin.

Comment
Thank you! Please write here, when I'll done it so I could update you great plugin.
or cancel

Parsed with GitHub Flavored Markdown
8.

0 votes

i18n and globalize2
6 comments Created about 1 month ago by batdevis

Title

Body
hi, does anyone use friendly_id with i18n (http://github.com/svenfuchs/rails-i18n) and globalize2 (http://github.com/joshmh/globalize2)? I'd want multiple url that points to the same resource: http://mysite.com/it/pages/azienda http://mysite.com/en/pages/company maybe I have to translate the slug? or use the scope? or add a language attribute to the slug? bye Devis_
or cancel

hi, does anyone use friendly_id with i18n (http://github.com/svenfuchs/rails-i18n) and globalize2 (http://github.com/joshmh/globalize2)?

I'd want multiple url that points to the same resource:

http://mysite.com/it/pages/azienda
http://mysite.com/en/pages/company

maybe I have to translate the slug?
or use the scope?
or add a language attribute to the slug?

bye

Devis_

Comments

norman Mon Sep 28 09:19:04 -0700 2009 | link

At the moment friendly_id doesn't have support for anything like that, but I think it's a great idea for a new feature in the next version.

Comment
At the moment friendly_id doesn't have support for anything like that, but I think it's a great idea for a new feature in the next version.
or cancel

activestylus Mon Sep 28 10:47:07 -0700 2009 | link

+1 on this - would be awesome to be able to pull it off with vanilla Rails I18n too

Comment
+1 on this - would be awesome to be able to pull it off with vanilla Rails I18n too
or cancel

norman Mon Sep 28 10:58:37 -0700 2009 | link

I see no reason why any extra dependencies would be necessary; probably all that will be needed is a locale field in the slug table. The query functionality would be very similar to the way scopes are handled.

I'm probably not going to have time to work on this for about 2 more weeks but I'll definitely include it in the next major version.

Comment
I see no reason why any extra dependencies would be necessary; probably all that will be needed is a locale field in the slug table. The query functionality would be very similar to the way scopes are handled. I'm probably not going to have time to work on this for about 2 more weeks but I'll definitely include it in the next major version.
or cancel

batdevis Tue Sep 29 08:55:11 -0700 2009 | link

I've a doubt about the routes implementation:

http://mysite.com/en/pages/company => 200 FOUND
http://mysite.com/en/pages/azienda => 404 NOT FOUND
http://mysite.com/it/pages/company => 404 NOT FOUND
http://mysite.com/it/pages/azienda => 200 FOUND

is it correct, in your opinion?

bye

Devis_

Comment
I've a doubt about the routes implementation: http://mysite.com/en/pages/company => 200 FOUND http://mysite.com/en/pages/azienda => 404 NOT FOUND http://mysite.com/it/pages/company => 404 NOT FOUND http://mysite.com/it/pages/azienda => 200 FOUND is it correct, in your opinion? bye Devis_
or cancel

batdevis Tue Sep 29 09:10:25 -0700 2009 | link

ahah this is much better:

http://mysite.com/en/pages/company => 200 FOUND
http://mysite.com/en/pages/azienda => 301 REDIRECT => http://mysite.com/en/pages/company
http://mysite.com/it/pages/company => 301 REDIRECT => http://mysite.com/it/pages/azienda
http://mysite.com/it/pages/azienda => 200 FOUND

Comment
ahah this is much better: http://mysite.com/en/pages/company => 200 FOUND http://mysite.com/en/pages/azienda => 301 REDIRECT => http://mysite.com/en/pages/company http://mysite.com/it/pages/company => 301 REDIRECT => http://mysite.com/it/pages/azienda http://mysite.com/it/pages/azienda => 200 FOUND
or cancel

norman Tue Sep 29 10:27:46 -0700 2009 | link

Yes, I think that makes good sense.

You could actually have an interesting philosophical discussion about whether the Italian version of a document and the English version are the "same." You could make a case that they are idempotent but not identical. If you believe that, then it may be more proper to do a 303 redirect (see other) rather than a 301 (moved permanently). However, the point is academic and it would likely make no real practical difference.

Regardless, I definitely think a redirect is much better than a 404, because somebody might want to view the English or Italian version of a resource, and try to manually change the IT to an EN or vice versa. Your app should be smart enough to figure out what the person wants.

Comment
Yes, I think that makes good sense. You could actually have an interesting philosophical discussion about whether the Italian version of a document and the English version are the "same." You could make a case that they are idempotent but not identical. If you believe that, then it may be more proper to do a 303 redirect (see other) rather than a 301 (moved permanently). However, the point is academic and it would likely make no real practical difference. Regardless, I definitely think a redirect is *much* better than a 404, because somebody might want to view the English or Italian version of a resource, and try to manually change the IT to an EN or vice versa. Your app should be smart enough to figure out what the person wants.
or cancel

Parsed with GitHub Flavored Markdown
16.

1 vote

Scope doesn't update when underlying record is changed
2 comments Created 26 days ago by nateabbott

Title

Body
Sorry for another issue... When you have a scoped slug, and the name of the scope changes, the slugs are not updated. i.e. I have users and posts, and there's the option :scope => :user. When I change the friendly_id of the user (which is name), the scope of the posts is not updated, and therefore they cannot be found by the find_one method (which is looking for an item with the new scope) Let me know if you need a more concrete example. Thanks for the help with this awesome gem!
or cancel

Sorry for another issue...

When you have a scoped slug, and the name of the scope changes, the slugs are not updated. i.e. I have users and posts, and there's the option :scope => :user. When I change the friendly_id of the user (which is name), the scope of the posts is not updated, and therefore they cannot be found by the find_one method (which is looking for an item with the new scope)

Let me know if you need a more concrete example. Thanks for the help with this awesome gem!

Comments

norman Tue Oct 27 06:49:40 -0700 2009 | link

Thanks, I think your explanation is actually crystal clear. I'll work on a patch for that, but it will likely not be ready today. Probably Thursday or Friday. I have a few other bugs related to scopes to work on, as well as a contributed patch pending, so I'll be doing a small overhaul of the scope features. In the mean time I'd suggest not using cached slugs if this is causing problems for your application, and count on being able to turn them back on by early next week at latest.

Comment
Thanks, I think your explanation is actually crystal clear. I'll work on a patch for that, but it will likely not be ready today. Probably Thursday or Friday. I have a few other bugs related to scopes to work on, as well as a contributed patch pending, so I'll be doing a small overhaul of the scope features. In the mean time I'd suggest not using cached slugs if this is causing problems for your application, and count on being able to turn them back on by early next week at latest.
or cancel

nateabbott Tue Oct 27 08:00:20 -0700 2009 | link

no problem -- thanks again for your work on this!

Comment
no problem -- thanks again for your work on this!
or cancel

Parsed with GitHub Flavored Markdown

Labels

▾
To do

Reserved words in sluggable models

Comments

i18n and globalize2

Comments

Scope doesn't update when underlying record is changed

Comments