Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expand meaning of plugins array to allow installing non-runtime plugins and inter-opt with installations property #22108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Mar 1, 2024

Current Behavior

Folks using the nx wrapper (nxw.js in .nx) install plugins in nx.json[installation][plugins].

This is a bit weird since there is also nx.json[plugins]

Expected Behavior

You can specify plugins in the top level plugins array.

This PR also adds a field called "runtime" that can be set to false to tell Nx that a plugin worker doesn't need to be spawned for a listed plugin.

This PR fixes up:

  • nx migrate support for plugins array contained versions
  • nx add, to add plugins to the plugins array by default
  • Plugin workers shutdown automatically if a plugin has no runtime functions

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested review from a team as code owners March 1, 2024 20:55
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 1, 2024 5:52pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant