Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure project with name undefined is not created #23097

Merged
merged 2 commits into from May 2, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

  • package manager workspaces plugin does some work at module load time, which has issues with those values not being updated.
  • If a plugin identifies a partial project config next to a non-nx project package.json which doesn't have a name, a project named undefined ends up being set in the graph. This then errors when running the task.

Expected Behavior

  • workspaces config stays up to date
  • no undefined

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner April 30, 2024 17:35
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 4:15pm

@FrozenPandaz FrozenPandaz merged commit 0fbd2f8 into nrwl:master May 2, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants