Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): v19 cleanup for Nx plugins #23104

Merged
merged 1 commit into from May 2, 2024
Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 30, 2024

This PR removes deprecated code that's been slated for removal in Nx 19 - mentioned as TODO(v19) comments.

Breaking Changes

  • CNW: create-nx-workspace no longer support --preset=empty and --preset=core, use --preset=apps and --preset=npm respectively. Deprecated in Nx 15.9.
  • Next.js: NX_ environment variables are no longer bundled into Next.js apps, use NEXT_PUBLIC instead. Deprecated in Nx 16.8.
  • Webpack, Storybook, Esbuild: NX_ environment variables are no longer bundled into browser bundles, use NX_PUBLIC instead. This removes the possibility of intentional bundling of NX_ variables. Deprecated in Nx 18.
  • Cypress: cypressComponentConfiguration generator removed from @nx/cypress, use configurationGeneratorinstead. Deprecated in Nx 16.8.
  • Cypress: cypressProjectGenerator generator removed from @nx/cypress, use configurationGenerator instead. Deprecated in Nx 15.9.
  • Expo: withNxWebpack removed from @nx/expo, use metro bundler (https://docs.expo.dev/guides/customizing-metro/) in app.json instead. There is a migration to handle this in Nx 19. Deprecated in Nx 15.8.

Deferred to v20

  • JS: classProperties.loose option removed from @nx/js/babel preset, use loose instead. Deprecated in Nx 17.0.
  • ESLint: Low priority task to "deviations from @typescript-eslint/recommended" for our lint rules. @JamesHenry will look at this later before Nx 20, but it is unimportant.
  • React: component testing does not work with Project Crystal, and we need the executor + built-in webpack configs to run CT. Will do a follow-up on this after Nx 19 release. Related issue: Support Cypress Component Testing with React and inferred targets #21546
  • Next.js: withStylus removal from @nx/next, use SASS instead. It hasn't worked, but we kept the file to throw an error when used. Deprecated in Nx 17.0.
  • Next.js: @nx/next:component and @nx/next:page generators to not derive the components and app/pages directory. Use nx g @nx/next:component apps/myapp/components/button instead. Deprecated in Nx 17.0.
  • Webpack: isolatedConfig option removal from @nx/webpack:webpack executor. There is a migration to handle this in Nx 19. Deprecated in in Nx 17.2.
  • Angular: executeWebpackDevServerBuilder removal from @nx/angular/executors, use executeDevServerBuilder instead. Deprecated in Nx 17.0.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 2, 2024 4:48pm

@jaysoo jaysoo force-pushed the feat/v19-cleanup-plugins branch 2 times, most recently from 84a4173 to d0c0204 Compare May 1, 2024 20:32
packages/angular/executors.ts Outdated Show resolved Hide resolved
@jaysoo jaysoo force-pushed the feat/v19-cleanup-plugins branch from b06a6be to 36e3790 Compare May 2, 2024 16:40
@jaysoo jaysoo requested a review from FrozenPandaz May 2, 2024 16:41
@FrozenPandaz FrozenPandaz merged commit 2e621f3 into master May 2, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the feat/v19-cleanup-plugins branch May 2, 2024 17:37
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants