Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gradle): add ci-workflow generator #23125

Merged
merged 1 commit into from May 2, 2024
Merged

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

There is no generator to setup a CI workflow for a Gradle workspace.

Expected Behavior

./nx g ci-workflow sets up a CI workflow for either Github Actions or CircleCI. More will be added later.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from juristr May 1, 2024 18:22
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 1, 2024 10:18pm

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

A few questions:

  • Do we want to include a GitHub Actions step for installing a particular version of Java?
  • Does Circle CI come with Gradle pre-installed? I don't see a setup step for Gradle in the Circle template

@FrozenPandaz FrozenPandaz merged commit 9da9f42 into master May 2, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the feat/gradle-ci-workflow branch May 2, 2024 16:25
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants