Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable DNS servers #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Configurable DNS servers #25

wants to merge 3 commits into from

Conversation

rcoxns
Copy link

@rcoxns rcoxns commented Jul 21, 2022

This PR mimics the --dns01-recursive-nameservers flag in cert-manager for split DNS.

Currently if you have an internal DNS server that responds with SOAs for zones that do not exist in NS1, you get errors such as:

  status:
    presented: false
    processing: true
    reason: 'PUT https://api.nsone.net/v1/zones/fake.domain.net/_acme-challenge.host.fake.fake.domain.net/TXT:
      403 User has no access for "_acme-challenge.host.fake.fake.domain.net"'

This appears to be because of how util.FindZoneByFqdn works. Being able to specify external nameservers fixes this issue.

Another solution would be to have this webhook query the NS1 api for zones and compare, but I opted for this as it keeps it in line with how cert-manager works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant